Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[#329] Don't translate languages #337

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

jardon
Copy link
Member

@jardon jardon commented Sep 30, 2024

  • Translate using locale if available

closes #329

- populate language list with untranslated language names
@jardon jardon marked this pull request as ready for review September 30, 2024 19:50
@jardon
Copy link
Member Author

jardon commented Sep 30, 2024

this currently has some language start from the right side of the listboxes. i can work on correcting that if that makes sense

@Muqtxdir
Copy link
Member

Muqtxdir commented Oct 1, 2024

im not sure, iget the langs starting from right issue
. can you share screenshot of that happening?

@jardon
Copy link
Member Author

jardon commented Oct 1, 2024

for some reason gettext seems to align the text differently based on language. this is what im talking about:
image

@axtloss
Copy link
Member

axtloss commented Oct 1, 2024

that's because these languages are written from right to left, aligning them like that makes sense and isn't something to fix

@axtloss
Copy link
Member

axtloss commented Oct 1, 2024

(also small note, it's not gettex doing this, it's gtk)

@kbdharun kbdharun merged commit d055de2 into Vanilla-OS:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language names should not be translated
4 participants